Skip to content

Improve LibraryView Accessibility #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-oit merged 2 commits into from
Jul 3, 2026
Merged

Improve LibraryView Accessibility #369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4145717
feat(ux): improve accessibility and ARIA labels in LibraryView
google-labs-jules[bot] Jul 3, 2026
4d5b783
feat(ux): improve accessibility and ARIA labels in LibraryView
google-labs-jules[bot] Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/features/library/LibraryView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,34 +91,38 @@ export const LibraryView: React.FC<LibraryViewProps> = ({ onEditEntity }) => {

<div className="library-controls">
<div className="search-box">
<Search className="search-icon" size={18} />
<Search className="search-icon" size={18} aria-hidden="true" />
<input
type="text"
type="search"
placeholder="Search library..."
value={search}
onChange={(e) => setSearch(e.target.value)}
aria-label="Search library"
/>
</div>

<div className="filter-chips">
<fieldset className="filter-chips" style={{ border: 'none', padding: 0, margin: 0 }}>
<legend className="sr-only">Filter by type</legend>
{ENTITY_TYPES.map((type) => (
<button
key={type.value}
className={`filter-chip ${filterType === type.value ? 'active' : ''}`}
onClick={() => setFilterType(type.value)}
aria-pressed={filterType === type.value}
>
{type.icon}
<span>{type.label}</span>
</button>
))}
</div>
</fieldset>

<div className="sort-controls">
<div className="sort-field-select">
<Calendar size={14} />
<Calendar size={14} aria-hidden="true" />
<select
value={sortBy}
onChange={(e) => setSortBy(e.target.value as 'name' | 'created_at' | 'updated_at')}
aria-label="Sort by"
>
{SORT_OPTIONS.map(opt => (
<option key={opt.value} value={opt.value}>{opt.label}</option>
Expand All @@ -129,14 +133,21 @@ export const LibraryView: React.FC<LibraryViewProps> = ({ onEditEntity }) => {
className="sort-order-btn"
onClick={() => setSortOrder(prev => prev === 'ASC' ? 'DESC' : 'ASC')}
title={sortOrder === 'ASC' ? 'Sort Ascending' : 'Sort Descending'}
aria-label={sortOrder === 'ASC' ? 'Sort Ascending' : 'Sort Descending'}
>
{sortOrder === 'ASC' ? <SortAsc size={18} /> : <SortDesc size={18} />}
{sortOrder === 'ASC' ? <SortAsc size={18} aria-hidden="true" /> : <SortDesc size={18} aria-hidden="true" />}
</button>
</div>
</div>
</div>

<div className="library-content">
<div aria-live="polite" role="status" className="sr-only">
{isLoading ? 'Loading entities...' : ''}
{!isLoading && entities.length === 0 ? 'No entities found matching your filters.' : ''}
{!isLoading && entities.length > 0 ? `Showing ${entities.length} entities.` : ''}
</div>

<div className="entity-grid-header">
<div className="col-name">Name</div>
<div className="col-type">Type</div>
Expand Down Expand Up @@ -185,6 +196,7 @@ export const LibraryView: React.FC<LibraryViewProps> = ({ onEditEntity }) => {
transform: `translateY(${virtualItem.start}px)`,
}}
onClick={() => entity.id && onEditEntity(entity.id)}
aria-label={`Edit ${entity.name}`}
>
<div className="col-name">
<span className="entity-name-text">{entity.name}</span>
Expand Down
Loading