Skip to content

Improve LibraryView Accessibility#369

Merged
d-oit merged 2 commits into
mainfrom
feat/library-a11y-1306224765763542868
Jul 3, 2026
Merged

Improve LibraryView Accessibility#369
d-oit merged 2 commits into
mainfrom
feat/library-a11y-1306224765763542868

Conversation

@d-oit

@d-oit d-oit commented Jul 3, 2026

Copy link
Copy Markdown
Owner

This change improves the accessibility of the LibraryView component by adding necessary ARIA attributes, semantic HTML, and a live region for screen reader announcements. These improvements ensure that users with assistive technologies can better navigate, search, and filter the entity library.


PR created automatically by Jules for task 1306224765763542868 started by @d-oit

- Change search input type to "search" and add aria-label
- Add aria-pressed to filter chips and group them with role="group"
- Add aria-label to sort field select and sort order button
- Add aria-label to entity list rows
- Add visually hidden status region for screen reader announcements
- Add aria-hidden to decorative icons

Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the config label Jul 3, 2026
@deepsource-io

deepsource-io Bot commented Jul 3, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in e7628c2...4d5b783 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Jul 3, 2026 5:28a.m. Review ↗
Python Jul 3, 2026 5:28a.m. Review ↗
Shell Jul 3, 2026 5:28a.m. Review ↗
SQL Jul 3, 2026 5:28a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codacy-production

codacy-production Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

- Change search input type to "search" and add aria-label
- Use semantic <fieldset> and <legend> for filter chips (addresses Codacy warning)
- Add aria-pressed to filter buttons
- Add aria-label to sort field select and sort order button
- Add aria-label to entity list rows
- Add visually hidden status region for screen reader announcements
- Add aria-hidden to decorative icons

Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
@d-oit d-oit merged commit 7a673f8 into main Jul 3, 2026
23 of 24 checks passed
@d-oit d-oit deleted the feat/library-a11y-1306224765763542868 branch July 3, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant