fix: Fix verification of proofs for specs with more than 2 children per node (in Rust implementation) - #290
Open
mappum wants to merge 2 commits into
Open
fix: Fix verification of proofs for specs with more than 2 children per node (in Rust implementation)#290mappum wants to merge 2 commits into
mappum wants to merge 2 commits into
Conversation
mappum
changed the title
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
===========================================
+ Coverage 51.39% 66.01% +14.62%
===========================================
Files 23 7 -16
Lines 9341 3652 -5689
Branches 86 0 -86
===========================================
- Hits 4801 2411 -2390
+ Misses 4175 1241 -2934
+ Partials 365 0 -365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Rust
right_branches_are_emptyimplementation, specifically for specs which have more than 2 children per node (e.g. Merk).