Skip to content

ci: add sonarcloud for go and js - #291

Merged
crodriguezvega merged 6 commits into
masterfrom
carlos/add-sonarcloud-go-js
Mar 12, 2024
Merged

ci: add sonarcloud for go and js#291
crodriguezvega merged 6 commits into
masterfrom
carlos/add-sonarcloud-go-js

Conversation

@crodriguezvega

Copy link
Copy Markdown

No description provided.

@DimitrisJim DimitrisJim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this was triggered in this PR too #290 (comment) that doesn't touch go/typescript.

we might need to tweak the sonar.exclusions?

Comment thread .github/workflows/typescript.yml Outdated
crodriguezvega and others added 2 commits March 8, 2024 19:59
Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Mar 8, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'ics23'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@crodriguezvega

Copy link
Copy Markdown
Author

seems like this was triggered in this PR too #290 (comment) that doesn't touch go/typescript.

we might need to tweak the sonar.exclusions?

Yeah, I am not sure if we can prevent that, because the project in SonarCloud was created for the whole repository... I didn't add a sonar-project.properties file for Rust, because it looks like code coverage support for Rust is not supported natively yet?

But I will update sonar.exclusions anyway.

@DimitrisJim DimitrisJim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! fine with merging this now and tweaking any issues in follow ups if they pop up.

@crodriguezvega
crodriguezvega merged commit b82084e into master Mar 12, 2024
@crodriguezvega
crodriguezvega deleted the carlos/add-sonarcloud-go-js branch March 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants