Skip to content

Fix two test-compile failures: String.write and String self-aliasing #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
conorbronsdon merged 2 commits into from
Jul 31, 2026
Merged

Fix two test-compile failures: String.write and String self-aliasing #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8420f89
Replace the removed String.write static call with the String constructor
conorbronsdon Jul 31, 2026
3864bbc
Build the stripped string into a temporary before reassigning
conorbronsdon Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/anchor_dump.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ from xml import fromstring, Element
def _esc(s_in: String, strip: Bool) -> String:
var s = s_in
if strip:
s = String(s.strip())
var stripped = String(s.strip())
s = stripped^
# order matters: backslash first
var out = String()
for ch in s.codepoint_slices():
Expand Down
2 changes: 1 addition & 1 deletion test/test_errors.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def _assert_lc(source: String, offset: Int, line: Int, col: Int) raises:


def _msg(e: Error) -> String:
return String.write(e)
return String(e)


def _strict_drain(var source: String) raises:
Expand Down
Loading