Fix two test-compile failures: String.write and String self-aliasing - #5
Merged
Conversation
Mojo's stdlib made String.write an instance method -- both overloads now take `mut self` -- so the old static form no longer resolves and the test module fails to parse. String.__init__ takes a variadic pack of Writable arguments and Error conforms to Writable, so String(e) is the direct replacement. Test-only; nothing in src/ used the static form. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
s.strip() borrows s while the String initializer is constructing s as its result, which the compiler now rejects: error: aliasing values passed immutably to 'args' argument and constructed as a result in 'String' initializer call Constructing into a temporary and moving it in separates the borrow from the assignment. This is why mojo-xml's conformance job was already red on 7/29, before the String.write breakage in the previous commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
conorbronsdon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent failures, both blocking the
testworkflow. mojo-xml is the only repo in the suite with more than one.1.
String.writeis no longer a static method (shared with mojo-feed, -html, -markdown, -template, -url)The stdlib made it an instance method, so both overloads take
mut selfand the old static call stopped resolving.String.__init__takes a variadic pack ofWritableargs andErrorconforms toWritable, soString(e)is the direct replacement. Verified green in CI on conorbronsdon/mojo-feed#5 first.2.
test/anchor_dump.mojo:18— self-aliasing in theStringinitializer (mojo-xml only)s = String(s.strip())borrowssfor the argument whilesis also the construction target. Building into a temporary and moving it in separates the two.This second one is why mojo-xml's conformance job was already red on 7/29, before the nightly bump that broke the other five — so this repo was never actually green after publish.
🤖 Generated with Claude Code