Skip to content

[KIP-932]: Add logging for acknowledgement apis #5537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pratyush Ranjan (PratRanj07) wants to merge 2 commits into
base: master
Choose a base branch
from
+19 −3
Open

[KIP-932]: Add logging for acknowledgement apis #5537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d82bb59
add logging for ack apis
PratRanj07 Jun 29, 2026
3ea6576
Check
PratRanj07 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/rdkafka_share_acknowledgement.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,8 +978,13 @@ rd_kafka_share_acknowledge_offset0(rd_kafka_share_t *rkshare,
return RD_KAFKA_RESP_ERR__INVALID_ARG;

/* Explicit acknowledge APIs require explicit acknowledgement mode */
if (rd_kafka_share_acknowledgement_mode_is_implicit(rkshare))
if (rd_kafka_share_acknowledgement_mode_is_implicit(rkshare)) {
rd_kafka_dbg(rkshare->rkshare_rk, CONSUMER, "SHAREACK",
"acknowledge(%s [%" PRId32 "] @%" PRId64
") rejected: implicit acknowledgement mode",
topic, partition, offset);
return RD_KAFKA_RESP_ERR__STATE;
}

/* Validate type - ACCEPT, RELEASE, REJECT allowed */
if (type < RD_KAFKA_SHARE_ACKNOWLEDGE_TYPE_ACCEPT ||
Expand All @@ -989,12 +994,23 @@ rd_kafka_share_acknowledge_offset0(rd_kafka_share_t *rkshare,
/* Find partition and entry containing the offset */
err = rd_kafka_share_find_ack_entry(rkshare, topic, partition, offset,
&entry, &idx);
if (err)
if (err) {
rd_kafka_dbg(rkshare->rkshare_rk, CONSUMER, "SHAREACK",
"Acknowledge(%s [%" PRId32 "] @%" PRId64
") rejected: offset not in any in-flight "
"acquired batch",
topic, partition, offset);
return err;
}

/* GAP records cannot be acknowledged */
if (entry->types[idx] == RD_KAFKA_SHARE_INTERNAL_ACK_GAP)
if (entry->types[idx] == RD_KAFKA_SHARE_INTERNAL_ACK_GAP) {
rd_kafka_dbg(rkshare->rkshare_rk, CONSUMER, "SHAREACK",
"Acknowledge(%s [%" PRId32 "] @%" PRId64
") rejected: offset is a GAP record",
topic, partition, offset);
return RD_KAFKA_RESP_ERR__STATE;
}

rd_kafka_share_update_acknowledgement_type(rkshare, entry, idx, type);

Expand Down