[KIP-932]: Add logging for acknowledgement apis - #5537
Open
Pratyush Ranjan (PratRanj07) wants to merge 2 commits into
Open
[KIP-932]: Add logging for acknowledgement apis#5537Pratyush Ranjan (PratRanj07) wants to merge 2 commits into
Pratyush Ranjan (PratRanj07) wants to merge 2 commits into
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Copilot started reviewing on behalf of
Pratyush Ranjan (PratRanj07)
June 29, 2026 06:52
View session
There was a problem hiding this comment.
Pull request overview
This PR adds additional debug logging for Share Consumer explicit acknowledgement APIs, improving observability when acknowledge requests are rejected due to invalid state or in-flight tracking conditions.
Changes:
- Log a debug message when explicit acknowledge APIs are called while in implicit acknowledgement mode.
- Log a debug message when an acknowledged offset is not found in any in-flight acquired batch.
- Log a debug message when attempting to acknowledge a GAP record.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /* Explicit acknowledge APIs require explicit acknowledgement mode */ | ||
| if (rd_kafka_share_acknowledgement_mode_is_implicit(rkshare)) | ||
| if (rd_kafka_share_acknowledgement_mode_is_implicit(rkshare)) { | ||
| rd_kafka_dbg(rkshare->rkshare_rk, CONSUMER, "SHAREACK", |
| &entry, &idx); | ||
| if (err) | ||
| if (err) { | ||
| rd_kafka_dbg(rkshare->rkshare_rk, CONSUMER, "SHAREACK", |
| /* GAP records cannot be acknowledged */ | ||
| if (entry->types[idx] == RD_KAFKA_SHARE_INTERNAL_ACK_GAP) | ||
| if (entry->types[idx] == RD_KAFKA_SHARE_INTERNAL_ACK_GAP) { | ||
| rd_kafka_dbg(rkshare->rkshare_rk, CONSUMER, "SHAREACK", |
airlock-confluentinc
Bot
force-pushed
the
dev_kip-932_add_ack_logging
branch
from
July 30, 2026 06:48
ecd844f to
3ea6576
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.