Skip to content

[KIP-932] use int64 for offset count in share ack commit offsets list #5533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kartik (sage-mode-hunter) wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −4
Open

[KIP-932] use int64 for offset count in share ack commit offsets list #5533

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d034566
[KIP-932] use int64 for offset count in share ack commit offsets list
sage-mode-hunter Jun 25, 2026
377f794
Re-run CLA check
sage-mode-hunter Jul 4, 2026
5a864c2
Re-run CLA status check
sage-mode-hunter Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/rdkafka_share_acknowledgement.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,14 +1130,13 @@ rd_kafka_share_build_partition_offsets_list(
rd_kafka_share_partition_offsets_list_t *list;
rd_kafka_share_partition_offsets_t *elem;
rd_kafka_share_ack_batch_entry_t *entry;
int total_offsets = 0;
int offset_idx = 0;
int64_t total_offsets = 0;
int64_t offset_idx = 0;
int j;

/* Count total offsets */
RD_LIST_FOREACH(entry, &batches->entries, j) {
total_offsets +=
(int)(entry->end_offset - entry->start_offset + 1);
total_offsets += entry->end_offset - entry->start_offset + 1;
}

list = rd_kafka_share_partition_offsets_list_new(1);
Expand Down