Skip to content

[KIP-932] use int64 for offset count in share ack commit offsets list - #5533

Open
Kartik (sage-mode-hunter) wants to merge 3 commits into
confluentinc:masterfrom
sage-mode-hunter:share-ack-offset-count-int64
Open

[KIP-932] use int64 for offset count in share ack commit offsets list#5533
Kartik (sage-mode-hunter) wants to merge 3 commits into
confluentinc:masterfrom
sage-mode-hunter:share-ack-offset-count-int64

Conversation

@sage-mode-hunter

Copy link
Copy Markdown

Offset count overflow in rd_kafka_share_build_partition_offsets_list:

  • total_offsets is a 32-bit int but sums int64 ranges from broker AcquiredRecords; past INT_MAX it overflows
  • the overflowed value sizes rd_kafka_share_partition_offsets_new while the fill loop writes one int64 per offset over the full range
  • offset_idx is also int and can wrap to a negative index
  • the sibling rd_kafka_share_build_response_rko already keeps this count in int64_t

Widened both to int64_t to match the int64 offsets array and that sibling.

@sage-mode-hunter
Kartik (sage-mode-hunter) requested a review from a team as a code owner June 25, 2026 09:13
@confluent-cla-assistant

Copy link
Copy Markdown

Please sign the Contributor License Agreement here before this PR can be approved.
❌ sage-mode-hunter
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@sage-mode-hunter

Copy link
Copy Markdown
Author

i have signed the CLA.

@sage-mode-hunter

Copy link
Copy Markdown
Author

Pushed an empty commit to re-run the CLA check. Signed it on my end already, so hopefully this clears the status.

@sage-mode-hunter

Copy link
Copy Markdown
Author

any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant