[KIP-932] use int64 for offset count in share ack commit offsets list - #5533
Open
Kartik (sage-mode-hunter) wants to merge 3 commits into
Open
[KIP-932] use int64 for offset count in share ack commit offsets list#5533Kartik (sage-mode-hunter) wants to merge 3 commits into
Kartik (sage-mode-hunter) wants to merge 3 commits into
Conversation
|
Please sign the Contributor License Agreement here before this PR can be approved. |
Author
|
i have signed the CLA. |
Author
|
Pushed an empty commit to re-run the CLA check. Signed it on my end already, so hopefully this clears the status. |
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offset count overflow in rd_kafka_share_build_partition_offsets_list:
Widened both to int64_t to match the int64 offsets array and that sibling.