Do not raise if record is already removed (e.g. with --deps-only) - #618
Draft
jaimergp wants to merge 7 commits into
Draft
Do not raise if record is already removed (e.g. with --deps-only)#618jaimergp wants to merge 7 commits into
jaimergp wants to merge 7 commits into
Conversation
Member
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Member
Author
|
I had to add a new block of code that essentially contradicts this comment: # Using a special instance of PrefixGraph to remove youngest child nodes that match
# the original requested specs. It's important to remove only the *youngest* child
# nodes, because a typical use might be `conda install --only-deps python=2 flask`,
# and in that case we'd want to keep python.
#
# What are we supposed to do if flask was already in the environment?
# We can't be removing stuff here that's already in the environment.
#
# What should be recorded for the user-requested specs in this case? Probably all
# direct dependencies of flask.I think we should actually NOT keep python, but I special cased it. My intuition as a user would be like |
…solver into only-deps-keyerror
jaimergp
marked this pull request as ready for review
February 24, 2025 09:26
jaimergp
marked this pull request as draft
February 24, 2025 09:28
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #613
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?