Skip to content

Do remove all packages to clear with --no-deps, without raising if missing - #632

Merged
jaimergp merged 2 commits into
mainfrom
only-deps-name
Mar 13, 2025
Merged

Do remove all packages to clear with --no-deps, without raising if missing#632
jaimergp merged 2 commits into
mainfrom
only-deps-name

Conversation

@jaimergp

@jaimergp jaimergp commented Mar 12, 2025

Copy link
Copy Markdown
Member

Description

Part of #618, without the controversy. Fixes part of #613.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review Mar 12, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 12, 2025
self.records[name] = installed
else:
self.records.pop(record.name)
self.records.pop(name, None)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using record.name here was an oversight.

@jaimergp jaimergp changed the title Do remove all packages to clear with --no-deps, without raising if mi… Do remove all packages to clear with --no-deps, without raising if missing Mar 12, 2025
@github-project-automation github-project-automation Bot moved this from 🆕 New to ✅ Approved in 🔎 Review Mar 12, 2025
@jaimergp
jaimergp marked this pull request as ready for review March 13, 2025 09:08
@jaimergp
jaimergp merged commit e3cccdb into main Mar 13, 2025
@github-project-automation github-project-automation Bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Mar 13, 2025
@jaimergp
jaimergp deleted the only-deps-name branch March 13, 2025 09:08
@github-actions github-actions Bot added the locked [bot] locked due to inactivity label Mar 14, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants