Skip to content

ci: limit vs2017-workload-vctools install to parallel jobs #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jezdez wants to merge 1 commit into from
+22 −2
Draft

ci: limit vs2017-workload-vctools install to parallel jobs #5965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,8 @@ jobs:
CONDA_SUBDIR: win-64

- name: Choco Install
if: runner.arch != 'ARM64'
# We may need the complete tooling so that cmake tests pass on windows
if: runner.arch != 'ARM64' && matrix.test-type == 'parallel'
# The parallel tests compile binaries with the Visual Studio 2017 toolchain
run: choco install visualstudio2017-workload-vctools

- name: Conda Install
Expand Down
20 changes: 20 additions & 0 deletions news/ci-limit-vs2017-choco.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
### Enhancements

* <news item>

### Bug fixes

* <news item>

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* Install the Visual Studio 2017 Build Tools only for Windows test jobs that
exercise the compiler toolchain.
Loading