Skip to content

ci: limit vs2017-workload-vctools install to parallel jobs - #5965

Draft
jezdez wants to merge 1 commit into
ci/heavy-test-markerfrom
ci/drop-vs2017-choco
Draft

ci: limit vs2017-workload-vctools install to parallel jobs#5965
jezdez wants to merge 1 commit into
ci/heavy-test-markerfrom
ci/drop-vs2017-choco

Conversation

@jezdez

@jezdez jezdez commented Apr 28, 2026

Copy link
Copy Markdown
Member

Description

Stacked on top of #5964.

The Windows workflow installs the Visual Studio 2017 Build Tools in every x64 matrix job. The step takes about 280 seconds. Several parallel tests compile binaries with that toolchain, while the serial test selection does not exercise it.

This PR keeps the Chocolatey installation in x64 parallel jobs and skips it in x64 serial jobs. ARM64 jobs remain unchanged.

This preserves the existing compiler and overlinking coverage while removing the install cost from half of the x64 Windows matrix.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests? — workflow-only change
  • Add / update outdated documentation? — no user-facing documentation affected

@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review Apr 28, 2026
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 28, 2026
@codspeed-hq

codspeed-hq Bot commented Apr 28, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks


Comparing ci/drop-vs2017-choco (cf8b6c1) with ci/heavy-test-marker (baa286f)

Open in CodSpeed

@jezdez
jezdez force-pushed the ci/drop-vs2017-choco branch from fc813b1 to e62b51e Compare July 24, 2026 15:33
@jezdez
jezdez force-pushed the ci/drop-vs2017-choco branch 2 times, most recently from 20625d6 to 584fb94 Compare July 24, 2026 17:48
The Windows parallel tests compile binaries with the Visual Studio 2017 toolchain. Keep the Chocolatey install for those jobs and skip it for serial jobs that do not exercise the compiler.
@jezdez
jezdez force-pushed the ci/drop-vs2017-choco branch from 584fb94 to cf8b6c1 Compare July 24, 2026 18:41
@jezdez jezdez changed the title ci: drop vs2017-workload-vctools choco install on Windows ci: limit vs2017-workload-vctools install to parallel jobs Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

2 participants