Skip to content

add maturin abi3 example recipe - #2883

Open
pavelzw wants to merge 7 commits into
conda-forge:mainfrom
pavelzw:abi3-recipe-example
Open

add maturin abi3 example recipe#2883
pavelzw wants to merge 7 commits into
conda-forge:mainfrom
pavelzw:abi3-recipe-example

Conversation

@pavelzw

@pavelzw pavelzw commented Jul 10, 2026

Copy link
Copy Markdown
Member

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

@netlify

netlify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 2829233
🔍 Latest deploy log https://app.netlify.com/projects/conda-forge-previews/deploys/6a57b64bd29c9a0008541538
😎 Deploy Preview https://deploy-preview-2883--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69
Accessibility: 96
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

CARGO_PROFILE_RELEASE_STRIP: symbols
CARGO_PROFILE_RELEASE_LTO: fat
content:
# Remove this wrapper once https://github.com/conda-forge/rust-activation-feedstock/pull/79 is merged

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends on conda-forge/cfep#63. i would also be fine with waiting until the CFEP is accepted... we could alternatively also for now just remove the cargo-auditable-wrapper from the example and add it once this is ready.

Comment thread docs/maintainer/example_recipes/maturin-abi3.md
@pavelzw

pavelzw commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

ci red is unrelated:

image

@pavelzw
pavelzw marked this pull request as ready for review July 10, 2026 08:40
@pavelzw
pavelzw requested a review from a team as a code owner July 10, 2026 08:40
@pavelzw

pavelzw commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

@conda-forge/core wdyt of this PR? xref #2883 (comment) i'm happy to adjust the other abi3 example recipes as well

Comment thread docs/_sidebar.json Outdated
- [`example-recipe.yaml`](https://github.com/conda-forge/python-abi3-feedstock/blob/main/recipe/example-recipe.yaml) (v1 format)
- [`example-meta.yaml`](https://github.com/conda-forge/python-abi3-feedstock/blob/main/recipe/example-meta.yaml) (v0 format)

## Recipe template

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this recipe example here adds anything more useful than the two listed above. Having this duplicated here will make things go out of sync fast.

`if: is_abi3` selectors are what let the same recipe handle both cases without further
changes.

`python-abi3` (when `is_abi3`): Ensures the extension is built and linked against the stable ABI.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true. The extension itself has to do it. See "Support in the upstream package" section at https://labs.quansight.org/blog/conda-abi3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants