Document run fails with conan_error, check for it in workspace - #20266
Draft
AbrilRBS wants to merge 1 commit into
Draft
Document run fails with conan_error, check for it in workspace#20266AbrilRBS wants to merge 1 commit into
AbrilRBS wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Failed creates in
workspacesubcommands now raise errors as expectedDocs: Omit
Closes #20258
In #19204 the behaviour of the install API changed not to raise, and let the CLI entrypoint do it (so that formatters could run). This change was not propagated here so the
runcalls (which does not have the auto-raise onconan_errorkeys) now did not stop execution when something failed, which could make it so a failedworkspace createcommand returned success status codes without having actually succesfully compiled