[bug] conan workspace create does not stop on build error

[spectralvoid0]

Describe the bug

I am using conan 2.31.2 on linux.

If conan workspace create encounters an error when building one of the packages in the workspace, it continues on to try to create the remaining packages. Packages that depend on the failed package will fail with a Missing binary error.

I think that conan workspace create should stop on the first error.

How to reproduce it

Conanfiles

pkga/conanfile.py

from conan import ConanFile

class PkgaConanfile(ConanFile):
    name = "pkga"
    version = "0.1"

    def build(self):
        self.run("false")

pkgb/conanfile.py

from conan import ConanFile

class PkgbConanfile(ConanFile):
    name = "pkgb"
    version = "0.1"

    def requirements(self):
        self.requires("pkga/0.1")

Commands

conan workspace init
conan workspace add pkga
conan workspace add pkgb
conan workspace create

[AbrilRBS]

Hi @spectralvoid0 thanks again for the detailed report, we appreciate it

This also seems like an actual bug. In #19204, the Conan behaviour changed not to raise on some commands directly from within the API. This change was not propagated to all the code bits, so this got affected.

I've proposed #20266 to fix and document the underlying issue, but we will be discussing internally if the current "don't raise exceptions in some commands" sounds good.