fix(release): remove uninitialized marker restored by checkout - #79
Merged
Conversation
The initialized-ext artifact has no ext/.gitkeep (pskel init removes it), but each binary job's fresh checkout restores the marker and the artifact download merges on top without deleting it. pskel then treats the initialized ext as uninitialized and attempts a fallback init, which fails on macOS runners where /usr/src/php does not exist. Drop the stale marker after downloading the artifact in the Linux and macOS jobs (Windows does not invoke pskel). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the macOS release job failure:
The
initialized-ext-releaseartifact contains noext/.gitkeep(pskel initremoves it), but each binary job's fresh checkout restores the marker from git, andactions/download-artifactmerges intoext/without deleting existing files.pskel packagethen saw thepskel_uninitializedmarker next to a fully initialized skeleton and attempted a fallback init — impossible on macOS runners where/usr/src/phpdoesn't exist (the Linux jobs only survived by wastefully re-initializing inside the container).Fix: drop the stale marker right after the artifact download in the
LinuxandmacOSjobs (Windowsdoesn't invoke pskel).Test plan
pskel packageproducephp_skeleton-…-darwin-bsdlibc.zip🤖 Generated with Claude Code