refactor(release): distribute extension sources via a single artifact - #80
Merged
Conversation
The Source job (Linux container) now always uploads the prepared ext/ as the release-ext artifact - initialized via the skeleton fallback when the template repo is untagged, or the committed sources for downstream projects. Every platform job (Linux, macOS, Windows) removes the checked-out ext/ and downloads the artifact unconditionally, so all binaries are built from identical sources and the needs-init conditionals and stale-marker workarounds disappear. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the cleaner initialization flow: the
Sourcejob (Linux container) is the single authority for extension sources — it checks initialization, runs thepskel init skeletonfallback when the template repo itself is tagged, and always uploads the resultingext/as therelease-extartifact. All platform jobs (Linux,macOS,Windows) delete the checked-outext/and download the artifact unconditionally.Benefits:
needs-initconditionals in the platform jobs and the stale.gitkeepmarker workaround (fix(release): remove uninitialized marker restored by checkout #79) disappear structurally — a fresh checkout can no longer reintroduce the uninitialized marker next to initialized sourcesext/just passes through the artifact)Test plan
needs-initreferences outside the Source job🤖 Generated with Claude Code