Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this is needed
A solution must complete its declared setup before activation, using short-lived authority confined to that installation. Authority owns issuance, verification and installation status; customer solutions must not implement those mechanisms.
What changed
This draft adds attempt-bound setup issuance and callback dispatch through the existing signed-delivery path. The latest bounded repair accepts successful 2xx acknowledgements and maps callback 5xx, network failures and client timeouts to
Unavailable, allowing the existing CLI delivery retry to retry. Actual caller cancellation and permanent refusal remain distinct. No new retry daemon or fabricated person consent was added.Verification and remaining blockers
At
99a1f594f009a1b69bcdb5cc6730e71d29b4368e, focused composition/state/Authority tests pass with race detection using the existing local workspace. Tests cover a 503 then successful retry of the same attempt, permanent refusal, and a client deadline while the caller context is live. Fresh independent review qualifies these bounded corrections for this draft only.Follow-up
0c3796d9b851cd970ce781c6973fd6fd3567caf0reproduces the existing local Go and Go/Python/TypeScript client outputs with released Codefly 0.1.221 and proto companion 0.0.18, updates 11 existing generated-content digests, and corrects the documented client-generation option. Independent review and the clean digest gate pass; no generated exemption was added. The full clean no-proxy gate still fails to load packages because of the dependency gaps below.Blocked; do not merge or release. The trusted-host fixture path still lacks accepted source evidence and cannot complete setup. Failed status/reason, durable retry exhaustion, administrator retry, restart recovery and preserving an old active revision remain incomplete. Runtime owns durable execution; this change only repairs the existing delivery retry signal. Lost responses still require idempotent callbacks.
The dependency codefly-dev/core#876 is a fork candidate not retrievable under the canonical Core Go module path in fresh-cache checks.
GOWORK=offcompilation still fails on missingResolvedSetup; Hop also needs a reachable generated setup-client revision. Full clean contract/consumer qualification, accepted setup authority and composed destination tests remain required. The experimental trusted-host receipt, startup reordering and fixture-role changes were excluded from this repair. Current main's conformance timing fix does not supersede it.