Repository navigation
feat(runtime): declare required request fields and qualify installation callbacks - #82
Open
gael-obin wants to merge 1 commit into
Conversation
…on callbacks Publish the previously exercised owner implementation for draft review.
gael-obin
marked this pull request as ready for review
November 3, 2026 04:36
Author
|
@antoinetoussaint-byte Please review the merge/release order for the runtime installation dependency chain. The downstream standalone build is blocked by the currently published runtime lacking the installation and required-field APIs; it is not being bypassed with a fork replacement or a skipped check.
The setup contract depends on Core declarations, Authority, and the matching host setup path. Please review those contract decisions and the receiver-first order; this is a request to advance the blocked approval chain, not to merge red or unqualified work. This account has no upstream merge permission. No release or deployment is claimed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An operation's JSON request must express required key presence in the generated interface without inventing a second schema generator.
RequiredFieldsadds that declaration to the existing runtime operation/interface path, creates a separate request definition per operation, and rejects invalid or misplaced wrappers. The installation receiver qualification fixture exercises the standardOnInstall/Servepath.Classification: fix at the generic solution-runtime owner. No credential verifier, handler bypass or solution-specific field vocabulary is introduced. Tests cover named-type isolation, request-only use, invalid declarations and schema emission.
Depends on installation setup client, itself based on installation receiver. This PR contains only the ten additional selected files, applied over current main; local Go workspaces and existing setup implementations are excluded. The setup-client branch is fork-only, so it cannot be the base of an upstream stacked PR. The qualification fixture needs that dependency; this PR does not duplicate it.
Validation retained from the selected cohort: runtime build/vet and focused request-schema checks; real Accounts installation receiver crossing exercised refusal, acknowledgement, delay, failure, revocation and new-release cases. Subsequent local installation used the standard callback and retained existing records. Independent publication review matched all ten source files.
Merge/release qualification remains open: compatible released dependencies, generated-contract freshness and clean standalone/combined CI must be qualified before merging. The composed run used local owner selections; publishing source does not make the committed dependency graph reproduce it. No production installation or active-upgrade guarantee is claimed.
CI and review follow-up
Opened for review at the author’s request. Removing draft status does not certify merge or release readiness. This follow-up inspected the published head and logs; it made no implementation changes and did not rerun tests.
No CI checks are reported for this head. The linked installation receiver/client prerequisites and standalone/combined qualification remain required. No checks is not a passing CI result.
No submitted GitHub reviews, inline review comments, or conversation comments were present in the captured state. Independent publication/status audits are scoped evidence, not owner approval.