Skip to content

Fix Unix process group termination #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cocoa-xu merged 2 commits into from
May 25, 2026
+224 −85
Merged

Fix Unix process group termination #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a4907d
Fix Unix process group termination
cocoa-xu May 25, 2026
eec497e
Bump macOS CI runner to 14
cocoa-xu May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
mix compile

macos:
runs-on: macos-13
runs-on: macos-14
env:
MIX_ENV: test
OTP_VERSION: "26.2.1"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/precompile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
cache/expty*.sha256

macos:
runs-on: macos-13
runs-on: macos-14
env:
MIX_ENV: prod
elixir_version: "1.16.2"
Expand Down
5 changes: 3 additions & 2 deletions c_src/nif_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <erl_nif.h>
#include <cstring>
#include <string>
#include <vector>

Expand All @@ -23,7 +24,7 @@ static ERL_NIF_TERM error(ErlNifEnv *env, const char *msg)
unsigned char * ptr;
size_t len = strlen(msg);
if ((ptr = enif_make_new_binary(env, len, &reason)) != nullptr) {
strcpy((char *)ptr, msg);
memcpy(ptr, msg, len);
return enif_make_tuple2(env, atom_error, reason);
} else {
ERL_NIF_TERM msg_term = enif_make_string(env, msg, ERL_NIF_LATIN1);
Expand All @@ -36,7 +37,7 @@ static ERL_NIF_TERM make_string(ErlNifEnv *env, const char *msg, bool& success)
unsigned char * ptr;
size_t len = strlen(msg);
if ((ptr = enif_make_new_binary(env, len, &erl_string)) != nullptr) {
strcpy((char *)ptr, msg);
memcpy(ptr, msg, len);
success = true;
return erl_string;
} else {
Expand Down
2 changes: 2 additions & 0 deletions c_src/unix/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
#define COMM_ERR_CHDIR 2
#define COMM_ERR_SETUID 3
#define COMM_ERR_SETGID 4
#define COMM_ERR_SETSID 5
#define COMM_ERR_TIOCSCTTY 6
Loading
Loading