fix: emit one Queue terminal response - #233
Merged
Merged
Conversation
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The hosted Destroyer Queue overload scenario exposed a real response-ordering race: a Queue command could complete just as the synchronous domain dispatch wait expired. Ingress emitted an indeterminate timeout and the actor later emitted the normal response for the same request. The extra frame shifted the client per-message-type FIFO, so a later accepted enqueue could appear retryably rejected and be sent again.
Failure evidence: https://github.com/cntryl/fitz-destroyer/actions/runs/33768148936/job/100691408320
Validation
cargo fmt --all -- --checkcargo test --workspacecargo clippy --locked --workspace --all-targets --all-features -- -D warnings -D clippy::pedanticcargo test api::runtime_ingress::tests::domain_backpressurecargo test domains::queue::sinkThe regression was observed red before the dispatcher arbitration was added (two terminal responses) and green afterward (exactly one).