Skip to content

Replace EventMachine with Concurrent::TimerTask - #4661

Merged
jochenehret merged 1 commit into
mainfrom
replace_eventmachine
Nov 21, 2025
Merged

Replace EventMachine with Concurrent::TimerTask#4661
jochenehret merged 1 commit into
mainfrom
replace_eventmachine

Conversation

@jochenehret

@jochenehret jochenehret commented Nov 17, 2025

Copy link
Copy Markdown
Contributor
  • A short explanation of the proposed change:
    This is a preparation for the Thin removal PR. It replaces EventMachine with Concurrent::TimerTask. The "thread_info_event_machine" metrics are removed.

  • An explanation of the use cases your change solves
    Remove outdated Gems.

  • Links to any other associated PRs
    Roadmap for Thin removal #4115

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@jochenehret
jochenehret force-pushed the replace_eventmachine branch 2 times, most recently from 677bc99 to 06662c9 Compare November 17, 2025 10:56
* preparation for Thin removal
* replace EventMachine with Concurrent::TimerTask
* remove "thread_info_event_machine" metrics
@jochenehret
jochenehret marked this pull request as ready for review November 19, 2025 10:01
@jochenehret jochenehret changed the title [DRAFT] Remove EventMachine Replace EventMachine with Concurrent::TimerTask Nov 19, 2025
@jochenehret
jochenehret requested review from a team November 19, 2025 15:51
@Samze

Samze commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Is it possible to hold off merging this for a few days?

We want to cut one more capi release that still supports thin features that will include this fix #4665 .

@Samze

Samze commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

Thanks for waiting, I released https://github.com/cloudfoundry/capi-release/releases/tag/1.222.0 so this is unblocked now!

@jochenehret
jochenehret merged commit 9fcbac0 into main Nov 21, 2025
16 of 17 checks passed
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Nov 21, 2025
Changes in cloud_controller_ng:

- Remove EventMachine from Puma
    PR: cloudfoundry/cloud_controller_ng#4661
    Author: Jochen Ehret <jochen.ehret@sap.com>
@moleske
moleske deleted the replace_eventmachine branch November 21, 2025 16:40
sethboyles pushed a commit to atanas-attodorov-wq/cloud_controller_ng that referenced this pull request Dec 11, 2025
* preparation for Thin removal
* replace EventMachine with Concurrent::TimerTask
* remove "thread_info_event_machine" metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants