Properly shut down Concurrent::TimerTasks when Puma is stopped - #4681
Merged
Conversation
philippthun
approved these changes
Nov 27, 2025
jochenehret
marked this pull request as ready for review
November 27, 2025 08:54
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Nov 27, 2025
Changes in cloud_controller_ng:
- build(deps): bump golang.org/x/crypto
PR: cloudfoundry/cloud_controller_ng#4667
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Properly shut down Concurrent::TimerTasks when Puma is stopped
PR: cloudfoundry/cloud_controller_ng#4681
Author: Jochen Ehret <jochen.ehret@sap.com>
- Add idempotent droplet creation
PR: cloudfoundry/cloud_controller_ng#4650
Author: Katharina Przybill <30441792+kathap@users.noreply.github.com>
- Remove unneeded "json_pure" Gem
PR: cloudfoundry/cloud_controller_ng#4677
Author: Jochen Ehret <jochen.ehret@sap.com>
sethboyles
pushed a commit
to atanas-attodorov-wq/cloud_controller_ng
that referenced
this pull request
Dec 11, 2025
…foundry#4681) * Properly shut down Concurrent::TimerTasks when Puma is stopped * Spec for PeriodicUpdater.stop_updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Correctly shut down Concurrent::TimerTasks when Puma is stopped.
An explanation of the use cases your change solves
The unit tests have been flaky since PR Replace EventMachine with Concurrent::TimerTask #4661 (replace EventMachine with TimerTasks). We saw a lot of
Mysql2::Error: Cannot truncate a table referenced in a foreign key constrainterrors. Root cause is not 100% understood, but it's likely due to an incomplete shutdown procedure.Links to any other associated PRs
Replace EventMachine with Concurrent::TimerTask #4661
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests