Skip to content

Remove not needed validates_unique for route mappings #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johha merged 1 commit into from
Oct 28, 2025
Merged

Remove not needed validates_unique for route mappings #4620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/models/runtime/route_mapping_model.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ def protocol_with_defaults

def validate
validates_presence [:app_port]
validates_unique %i[app_guid route_guid process_type app_port]

validate_weight
end
Expand All @@ -60,6 +59,15 @@ def has_app_port_specified?
app_port != ProcessModel::NO_APP_PORT_SPECIFIED
end

def around_save
yield
rescue Sequel::UniqueConstraintViolation => e
raise e unless e.message.include?('route_mappings_app_guid_route_guid_process_type_app_port_key')

errors.add(%i[app_guid route_guid process_type app_port], :unique)
raise validation_failed_error
end

private

def logger
Expand Down