Remove not needed validates_unique for route mappings - #4620
Merged
Conversation
Table `route_mappings` has a unique constraint for columns `app_guid`, `route_guid`, `process_type` and `app_port`. Therefore we can rely on the DB to catch uniqueness errors and remove the sequel `validates_unique` in the model. This reduces the number of DB queries as the following query is now skipped: ```SQL SELECT 1 AS \"one\" FROM \"route_mappings\" WHERE ((\"app_guid\" = <app_guid>) AND (\"route_guid\" = <route_guid>) AND (\"process_type\" = 'web') AND (\"app_port\" = <port>)) LIMIT 1" ```
jochenehret
approved these changes
Oct 28, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Oct 28, 2025
Changes in cloud_controller_ng:
- Remove not needed `validates_unique` for route mappings
PR: cloudfoundry/cloud_controller_ng#4620
Author: Johannes Haass <johannes.haass@sap.com>
sethboyles
pushed a commit
to atanas-attodorov-wq/cloud_controller_ng
that referenced
this pull request
Dec 11, 2025
…#4620) Table `route_mappings` has a unique constraint for columns `app_guid`, `route_guid`, `process_type` and `app_port`. Therefore we can rely on the DB to catch uniqueness errors and remove the sequel `validates_unique` in the model. This reduces the number of DB queries as the following query is now skipped: ```SQL SELECT 1 AS \"one\" FROM \"route_mappings\" WHERE ((\"app_guid\" = <app_guid>) AND (\"route_guid\" = <route_guid>) AND (\"process_type\" = 'web') AND (\"app_port\" = <port>)) LIMIT 1" ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table
route_mappingshas a unique constraint for columnsapp_guid,route_guid,process_typeandapp_port. Therefore we can rely on the DB to catch uniqueness errors and remove the sequelvalidates_uniquein the model. This reduces the number of DB queries as the following query is now skipped:I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests