Skip to content

fix: ECOMPROMISED lockfile crash under disk I/O pressure #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sureiya wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ECOMPROMISED lockfile crash under disk I/O pressure #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/fs/locked-file-system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ function createLockOptions(request: LockRequest, lockfilePath: string): LockOpti
retries: request.retries ?? DEFAULT_LOCK_RETRIES,
realpath: false,
lockfilePath,
// Don't crash on ECOMPROMISED — the lock is silently released instead.
// This prevents process crashes under disk I/O pressure.
onCompromised: request.onCompromised ?? (() => {}),
};
if (typeof request.onCompromised === "function") {
options.onCompromised = request.onCompromised;
}
return options;
}

Expand Down Expand Up @@ -108,7 +108,11 @@ export class LockedFileSystem {
return await operation();
} finally {
for (const release of releases.reverse()) {
await release();
try {
await release();
} catch {
/* lock already released (e.g. ECOMPROMISED) */
}
}
}
}
Expand Down