fix: ECOMPROMISED lockfile crash under disk I/O pressure - #555
Open
Sureiya wants to merge 1 commit into
Open
Conversation
The onCompromised handler no longer throws, preventing process crashes under disk I/O pressure. Lock release errors in the withLocks finally block are caught silently.
|
PR author is not in the allowed authors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
onCompromisedhandler in proper-lockfile throws, crashing the process. Under heavy disk I/O (large git diffs, system updates), lockfiles can be compromised, causing kanban to crash every ~15 minutes.This makes
onCompromiseda silent no-op instead, and catches lock release errors in thewithLocksfinally block.