docs(audiences): document OR filter group with AND exclusion pattern - #2349
Open
george-dilthey wants to merge 1 commit into
Open
docs(audiences): document OR filter group with AND exclusion pattern#2349george-dilthey wants to merge 1 commit into
george-dilthey wants to merge 1 commit into
Conversation
… fix top-level connector docs
Contributor
george-dilthey
marked this pull request as ready for review
August 26, 2026 21:39
This was referenced Aug 27, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a second filter group example to
docs/audiences.mdshowing the(A OR B OR C) AND D = falsepattern — conditions in a filter group switched to OR, combined via a top-level AND filter to act as a global exclusion. Also corrected an existing claim that top-level filters are "always AND" (they default to AND but the connector is toggleable to OR).Why
Intercom conversation #215475622490195 (Sierra / Candice Meier) was escalated to a human because Fin couldn't explain how to build a dynamic exclusion segment. The customer had a suppression audience of Partners but needed to carve out the ~70 Partners who are also Customers or Prospects (Visa, Mastercard, Stripe). Human support agent Bo Morin answered by explaining the AND group pattern: put the OR conditions (Competitor OR Partner OR related contact) in a filter group, and add the Customer/Prospect exclusion as a separate top-level filter set to AND.
The existing doc's filter group example only showed
A AND B AND (C OR D)— it never showed the inverse case where the OR conditions are in the group and the exclusion is a top-level filter. That was the specific gap that caused the escalation.Additionally, the existing line said "All top-level filters are joined with AND" — the verifier confirmed this is incorrect. The top-level connector is also user-toggleable to OR (default is AND, but not locked). This was corrected.
Source link(s)
#dust-supportcorroboration (filter groups confirmed): https://clay-hq.slack.com/archives/C08AP3K53H9/p1786710757628519apps/frontend/src/components/FilterBuilder/FilterBuilderGroupConditional.tsx:51-94— AND/OR toggle confirmed for both group-level and top-level connectorsservices/audiences/src/query/compilerv3/frontends/json/json-frontend.ts:145—combinationMode(AND/OR) respected at compile timeUncertainties
None. Both edits are verified PASS by the verifier sub-agent against live product code.
Related observations
Many open PRs touch
docs/audiences.md(#2179, #2184, #2192, #2195, #2202, #2203, #2204, #2210, #2215, #2224, #2225, #2231, #2232, #2245, #2251, #2261, #2272, #2280, #2288, #2291, #2295, #2303, #2305, #2321, #2323, #2345, #2348). None of them cover the filter group AND/OR exclusion pattern or the top-level connector correction documented here — all address other topics. Reviewers should reconcile these PRs at merge time.Closes DOC-2104