Repository navigation
fix(revkiller): bump version to 2.0.11 so stable users get the #598 changes - #606
Merged
Merged
Conversation
…hanges Release #605 shipped Rev Killer code from #598 under 2.0.10, the version stable main already had from #564, so the client's version-equality update check never prompts existing installs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV
chsami
added a commit
that referenced
this pull request
Oct 14, 2026
…609) Development fixed the 2.6.25 long item-price API independently in #566 by narrowing prices back to int, while main got #564, which keeps prices and totals in long. Since then every development -> main release has had to keep main's copy of these files by hand. Bring #564's content into development: long price/total arithmetic in Discord, Humidifier, LunarPlankMake, TanLeather, MoonlightMoth, revKiller, Thieving, PVirewatchKiller and WildernessAgility, the minClientVersion = "2.6.25" bumps for revKiller and Zulrah, and docs/RUNELITE_1_13_MIGRATION.md. Development's newer revKiller version 2.0.11 (#606) and its non-deprecated VarClientID.TOPLEVEL_PANEL read in PrayerMarkerOverlay (same varc 171 as VarClientInt.INVENTORY_TAB) stay. Claude-Session: https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#598 changed Rev Killer (
revKillerScript.java) and bumped development from 2.0.9 to 2.0.10. Stablemainwas already on 2.0.10 from #564, so release #605 put the #598 code on main under the same version string:0e5ce54..31318a2changesrevKillerScript.javaby +11/-4 lines, and the version stays2.0.10before and after.MicrobotPluginManager.getOutdatedPluginUpdateonly flags an update when the manifest version differs from the installed version (latestVersion.equals(installedVersion)). Anyone who installed 2.0.10 from #564 is therefore never told about the #598 code.Change
revKillerPlugin.versiongoes from2.0.10to2.0.11. Nothing else changes.Audit of other plugins
I wrote a script that reads each plugin's version the same way
getPluginDescriptorInfodoes (the firstversion = "..."in the*Plugin.java) and compares the plugin's source and resource trees between two refs:0e5ce54->origin/main): 12 plugins changed code. 11 of them got a higher version. Rev Killer is the only one whose code changed while its version stayed the same.origin/mainvsorigin/development: 10 plugins have different code under the same version: discord, humidifier, lunarplankmake, lunartanner, moonlightmoth, revkiller, thieving, virewatch, wildernessagility, zulrah. In every case the difference comes from [codex] Migrate Hub plugins for Microbot 2.6.25 / RuneLite 1.13 #564 (the RuneLite 1.13 price-API fix andminClientVersion = "2.6.25"). That fix exists only on main and was never merged back into development. So for these plugins it is main that has the newer code, not development. Stable users already run the merged code, and [codex] Migrate Hub plugins for Microbot 2.6.25 / RuneLite 1.13 #564 bumped each of these plugins when it landed (for example discord 1.0.0 -> 1.0.1 and zulrah 1.0.1 -> 1.0.2). Bumping them here would ship no new code, so I left them alone.git merge-tree origin/main HEADshows the next development -> main release merges cleanly and keeps main's [codex] Migrate Hub plugins for Microbot 2.6.25 / RuneLite 1.13 #564 lines. The merged Rev Killer hasversion = "2.0.11"andminClientVersion = "2.6.25".Found but not changed (out of scope)
version = X.VERSION):HueycoatlPrayer,farmingcontract,theatreandsisyphusinfernalpact. The build regexversion\s*=\s*"([^"]+)"is case-sensitive, so it never matches them, andplugins.jsonfalls back toDEFAULT_VERSION(1.0.0) on every release. Version bumps in those plugins never reach the update check. Thelatest-releaseassets confirm it: each of the four exists only as a-1.0.0.jar. The fix belongs ingradle/plugin-utils.gradleor in those plugins' declarations.421a3bd) and Development > main #172 (0b8019b). I did not check whether those changes affect behaviour or are just refactors, and I bumped none of them.Testing
./gradlew compileJava compileTestJavapasses../gradlew revKillerPluginJarbuildsrevKillerPlugin-2.0.11.jar.origin/main=2.0.10->HEAD=2.0.11and no longer flags it.🤖 Generated with Claude Code
https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV