Skip to content

fix(revkiller): bump version to 2.0.11 so stable users get the #598 changes - #606

Merged
chsami merged 1 commit into
developmentfrom
claude/hub-revkiller-version
Oct 13, 2026
Merged

chsami merged 1 commit into
developmentfrom
claude/hub-revkiller-version

Conversation

@chsami

@chsami chsami commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Problem

#598 changed Rev Killer (revKillerScript.java) and bumped development from 2.0.9 to 2.0.10. Stable main was already on 2.0.10 from #564, so release #605 put the #598 code on main under the same version string: 0e5ce54..31318a2 changes revKillerScript.java by +11/-4 lines, and the version stays 2.0.10 before and after.

MicrobotPluginManager.getOutdatedPluginUpdate only flags an update when the manifest version differs from the installed version (latestVersion.equals(installedVersion)). Anyone who installed 2.0.10 from #564 is therefore never told about the #598 code.

Change

  • revKillerPlugin.version goes from 2.0.10 to 2.0.11. Nothing else changes.

Audit of other plugins

I wrote a script that reads each plugin's version the same way getPluginDescriptorInfo does (the first version = "..." in the *Plugin.java) and compares the plugin's source and resource trees between two refs:

  • Release Release Hub development updates for Microbot 2.6.32 #605 (0e5ce54 -> origin/main): 12 plugins changed code. 11 of them got a higher version. Rev Killer is the only one whose code changed while its version stayed the same.
  • origin/main vs origin/development: 10 plugins have different code under the same version: discord, humidifier, lunarplankmake, lunartanner, moonlightmoth, revkiller, thieving, virewatch, wildernessagility, zulrah. In every case the difference comes from [codex] Migrate Hub plugins for Microbot 2.6.25 / RuneLite 1.13 #564 (the RuneLite 1.13 price-API fix and minClientVersion = "2.6.25"). That fix exists only on main and was never merged back into development. So for these plugins it is main that has the newer code, not development. Stable users already run the merged code, and [codex] Migrate Hub plugins for Microbot 2.6.25 / RuneLite 1.13 #564 bumped each of these plugins when it landed (for example discord 1.0.0 -> 1.0.1 and zulrah 1.0.1 -> 1.0.2). Bumping them here would ship no new code, so I left them alone. git merge-tree origin/main HEAD shows the next development -> main release merges cleanly and keeps main's [codex] Migrate Hub plugins for Microbot 2.6.25 / RuneLite 1.13 #564 lines. The merged Rev Killer has version = "2.0.11" and minClientVersion = "2.6.25".

Found but not changed (out of scope)

  • These plugins declare their version through an upper-case constant (version = X.VERSION): HueycoatlPrayer, farmingcontract, theatre and sisyphusinfernalpact. The build regex version\s*=\s*"([^"]+)" is case-sensitive, so it never matches them, and plugins.json falls back to DEFAULT_VERSION (1.0.0) on every release. Version bumps in those plugins never reach the update check. The latest-release assets confirm it: each of the four exists only as a -1.0.0.jar. The fix belongs in gradle/plugin-utils.gradle or in those plugins' declarations.
  • Looking back through the history: 40 plugins besides Rev Killer have shipped more than one code state on main under the version they still carry today (three of them are the upper-case-constant plugins above). Most of these come from the large development merges Development #377 (421a3bd) and Development > main #172 (0b8019b). I did not check whether those changes affect behaviour or are just refactors, and I bumped none of them.

Testing

  • ./gradlew compileJava compileTestJava passes.
  • ./gradlew revKillerPluginJar builds revKillerPlugin-2.0.11.jar.
  • After the change, the audit shows Rev Killer as origin/main=2.0.10 -> HEAD=2.0.11 and no longer flags it.
  • There is no unit test, because the change is a single version constant.
  • Not verified: I did not live-test in the client. The fix reaches stable users only with the next Hub release (development -> main), which is not part of this PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV

…hanges

Release #605 shipped Rev Killer code from #598 under 2.0.10, the version
stable main already had from #564, so the client's version-equality update
check never prompts existing installs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV
@chsami
chsami merged commit 328df10 into development Oct 13, 2026
1 check passed
chsami added a commit that referenced this pull request Oct 14, 2026
…609)

Development fixed the 2.6.25 long item-price API independently in #566
by narrowing prices back to int, while main got #564, which keeps
prices and totals in long. Since then every development -> main release
has had to keep main's copy of these files by hand.

Bring #564's content into development: long price/total arithmetic in
Discord, Humidifier, LunarPlankMake, TanLeather, MoonlightMoth,
revKiller, Thieving, PVirewatchKiller and WildernessAgility, the
minClientVersion = "2.6.25" bumps for revKiller and Zulrah, and
docs/RUNELITE_1_13_MIGRATION.md. Development's newer revKiller version
2.0.11 (#606) and its non-deprecated VarClientID.TOPLEVEL_PANEL read in
PrayerMarkerOverlay (same varc 171 as VarClientInt.INVENTORY_TAB) stay.


Claude-Session: https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant