Skip to content

fix: backport #564 RuneLite 1.13 price changes into development - #609

Merged
chsami merged 1 commit into
developmentfrom
claude/hub-backport-564
Oct 14, 2026
Merged

chsami merged 1 commit into
developmentfrom
claude/hub-backport-564

Conversation

@chsami

@chsami chsami commented Oct 14, 2026

Copy link
Copy Markdown
Owner

Problem

#564 (the RuneLite 1.13 / client 2.6.25 item-price fix) was merged only into main. Development got its own fix in #566, which narrowed the new long prices back to int. So the same files now differ between the two branches, and each development -> main release since then (#595, #605) has had to keep main's copy of them by hand.

Change

For the files #564 touched, this PR applies main's content on top of development:

  • Prices, totals and profit counters stay long in Discord, Humidifier, LunarPlankMake, TanLeather, MoonlightMoth (overlay and script), revKiller, Thieving (comparingLong), PVirewatchKiller (formatNumber(long)) and WildernessAgility (mapToLong, value getters now return long). Lunar, TanLeather and Humidifier show profit with QuantityFormatter.quantityToStackSize(long).
  • revKiller and Zulrah get minClientVersion = "2.6.25".
  • Adds docs/RUNELITE_1_13_MIGRATION.md.
  • Adds missing trailing newlines in the TanLeather, WildernessAgility, Discord and revKiller files, as main has them.

Two of development's changes stay as they are on purpose:

There are no other plugin version bumps. Stable users already have this code under the versions main shipped, and development's versions are equal to or higher than main's for every plugin touched.

The other six files #564 touched (AutoFiremakingPlus overlay and plugin, the Humidifier, LunarPlankMake, MoonlightMoth and Thieving plugin classes) were already identical on both branches.

git diff origin/main 352dc76 -- <#564 files>

--- a/src/main/java/net/runelite/client/plugins/microbot/revkiller/revKillerPlugin.java
+++ b/src/main/java/net/runelite/client/plugins/microbot/revkiller/revKillerPlugin.java
-    public static final String version = "2.0.10";
+    public static final String version = "2.0.11";
--- a/src/main/java/net/runelite/client/plugins/microbot/zulrah/overlays/PrayerMarkerOverlay.java
+++ b/src/main/java/net/runelite/client/plugins/microbot/zulrah/overlays/PrayerMarkerOverlay.java
-import net.runelite.api.VarClientInt;
+import net.runelite.api.gameval.VarClientID;
-					if (client.getVarcIntValue(VarClientInt.INVENTORY_TAB) == 5)
+					if (client.getVarcIntValue(VarClientID.TOPLEVEL_PANEL) == 5)

Nothing else differs from main in those 22 files.

git merge-tree --write-tree origin/main 352dc76

8ce0f2fe5783bf52c7cb9f6a5c453a468212b3fb

Exit code 0, so it merges cleanly with no conflicts. One thing to know: the merge base (362786b) already has the TOPLEVEL_PANEL line, so a plain merge keeps main's INVENTORY_TAB line there. A squash release from development would move main to TOPLEVEL_PANEL. Both read varc 171, so the behaviour is the same either way.

Testing

  • ./gradlew compileJava compileTestJava test against client 2.6.32 (the latest release, resolved by the build): BUILD SUCCESSFUL. 790 tests ran, 0 failures, 0 errors, 2 skipped.
  • New PVirewatchKillerPluginFormatNumberTest: formatNumber(3_000_000_000L) returns "3000m", and the existing k/m formatting for small totals is unchanged. With development's PVirewatchKillerPlugin.java put back, the test fails to compile (possible lossy conversion from long to int). With this change it passes.

Not verified: no live in-game run. These are type-widening changes that match what stable users already run from main. The other plugins' profit and total displays have no tests, so they are covered only by compiling.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV

Development fixed the 2.6.25 long item-price API independently in #566
by narrowing prices back to int, while main got #564, which keeps
prices and totals in long. Since then every development -> main release
has had to keep main's copy of these files by hand.

Bring #564's content into development: long price/total arithmetic in
Discord, Humidifier, LunarPlankMake, TanLeather, MoonlightMoth,
revKiller, Thieving, PVirewatchKiller and WildernessAgility, the
minClientVersion = "2.6.25" bumps for revKiller and Zulrah, and
docs/RUNELITE_1_13_MIGRATION.md. Development's newer revKiller version
2.0.11 (#606) and its non-deprecated VarClientID.TOPLEVEL_PANEL read in
PrayerMarkerOverlay (same varc 171 as VarClientInt.INVENTORY_TAB) stay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV
@chsami
chsami merged commit 212e749 into development Oct 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant