Skip to content

Fix vacuous-pass assertion in collection.config schema/EF conflict test #7526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nimra3261 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

Fix vacuous-pass assertion in collection.config schema/EF conflict test #7526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions clients/new-js/packages/chromadb/test/collection.config.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,15 +611,13 @@ describe("embedding function null vs undefined handling", () => {
const schema = new Schema();
const providedEf = new DefaultSpaceCustomEmbeddingFunction("i_want_l2", 5);

try {
const collection = await client.createCollection({
await expect(
client.createCollection({
name: "test_provided_over_schema",
schema,
embeddingFunction: providedEf,
});
} catch (error) {
expect(error).toBeDefined();
}
}),
).rejects.toBeDefined();
});
test("it should use provided embedding function if no schema", async () => {
const providedEf = new DefaultSpaceCustomEmbeddingFunction("i_want_l2", 5);
Expand Down