Fix vacuous-pass assertion in collection.config schema/EF conflict test - #7526
Open
Nimra3261 wants to merge 1 commit into
Open
Fix vacuous-pass assertion in collection.config schema/EF conflict test#7526Nimra3261 wants to merge 1 commit into
Nimra3261 wants to merge 1 commit into
Conversation
"it should error if both schema and embedding function are provided" wrapped its assertion inside the catch block with no fallback: if createCollection() didn't throw, the catch body (and its expect(error).toBeDefined() check) never ran, and the test passed silently without ever exercising the assertion. Rewritten as await expect(...).rejects.toBeDefined(), matching the pattern applied in chroma-core#7508/chroma-core#7509/chroma-core#7525. Flagged by review on chroma-core#7525: chroma-core#7525 (review) Addresses chroma-core#2801
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"it should error if both schema and embedding function are provided" wrapped its assertion inside the catch block with no fallback:
If
createCollection()didn't throw, the catch body (and itsexpect(error).toBeDefined()check) never ran, and the test passed silently without ever exercising the assertion.Rewritten as
await expect(...).rejects.toBeDefined(), matching the pattern applied in #7508/#7509/#7525.Flagged by review on #7525 pointing out this same shape recurs in a few places - this is the one instance not already covered by an open PR.
Addresses #2801