Edirol SD-90 adaptation.

[christofmuc]

…No proof Sysex exists in the Internet, so this is purely based on the sysex documentation.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 39a61b81-5734-457a-ba87-c57265bcbf9e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch adaptation/edirol-sd90

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[christofmuc]

Release-readiness follow-up (no fixes applied here):

• Non-channel-specific discovery receives 0x7F from KnobKraft, but createDeviceDetectMessage masks it to 0x1F. Preserve the broadcast ID and test the host's real call.
• Reordered valid DT1 blocks are accepted, then conversion assigns their payloads to addresses by list position and produces an invalid dump. Fix both conversion paths with address-based matching or explicit canonical-order validation; shared concern with Add Roland JD-800 #538/[synth] Initial Roland Sound Canvas SC-88 adaptation #539.
• Existing coverage is synthetic (24 tests pass on Python 3.12). Add full 32-part request sequencing/boundary tests and independent protocol assertions; describe support as temporary part patches, not stored user programs.

This PR currently targets #539's branch, not master. No hardware validation was performed in this review.