Skip to content

Fix/ressource leak #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mphschmitt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/ressource leak #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee687a6
Trio: Close file pointer on error.
mphschmitt Feb 25, 2022
435638d
Overlaps: close file desciptors.
mphschmitt Feb 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Overlaps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24165,14 +24165,19 @@ char* output_file_name, ma_hit_t_alloc** reverse_sources, R_to_U* ruIndex)
char* gfa_name = (char*)malloc(strlen(output_file_name)+55);
sprintf(gfa_name, "%s.all.debug.source.bin", output_file_name);
fp = fopen(gfa_name, "r"); if(!fp) return 0;
fclose(fp); /* Prevent ressource leak.*/
sprintf(gfa_name, "%s.all.debug.reverse.bin", output_file_name);
fp = fopen(gfa_name, "r"); if(!fp) return 0;
fclose(fp); /* Prevent ressource leak.*/
sprintf(gfa_name, "%s.all.debug.coverage_cut.bin", output_file_name);
fp = fopen(gfa_name, "r"); if(!fp) return 0;
fclose(fp); /* Prevent ressource leak.*/
sprintf(gfa_name, "%s.all.debug.ruIndex.bin", output_file_name);
fp = fopen(gfa_name, "r"); if(!fp) return 0;
fclose(fp); /* Prevent ressource leak.*/
sprintf(gfa_name, "%s.all.debug.asg_t.bin", output_file_name);
fp = fopen(gfa_name, "r"); if(!fp) return 0;
fclose(fp); /* Prevent ressource leak.*/
if((sg == NULL) || (sources == NULL) || (coverage_cut == NULL) || (reverse_sources == NULL) ||
(ruIndex == NULL))
{
Expand Down
2 changes: 1 addition & 1 deletion Trio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ static yak_ch_t *yak_ch_restore_core(yak_ch_t *ch0, const char *fn, int mode, ..
if (mode_err) return 0;

if ((fp = fopen(fn, "rb")) == 0) return 0;
if (fread(magic, 1, 4, fp) != 4) return 0;
if (fread(magic, 1, 4, fp) != 4) { fclose(fp); return 0; }
if (strncmp(magic, YAK_MAGIC, 4) != 0) {
fprintf(stderr, "ERROR: wrong file magic.\n");
fclose(fp);
Expand Down