Skip to content

Allow injection of the commit hash and timestamp for hermetic builds. #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheeaun merged 5 commits into from
Jul 8, 2026
Merged

Allow injection of the commit hash and timestamp for hermetic builds. #1543

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef1920a
Allow injection of the commit hash and timestamp for hermetic builds.
SamirTalwar Jun 19, 2026
e450df1
Allow mocking out the build time too.
SamirTalwar Jun 19, 2026
e09e527
Delete .prettierrc.
SamirTalwar Jun 20, 2026
0b78702
Set `buildTime` from an env var, but leave `now` alone.
SamirTalwar Jul 7, 2026
8a7fda5
Merge remote-tracking branch 'origin/main' into inject-commit-hash
SamirTalwar Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 33 additions & 13 deletions vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,25 +23,45 @@ const {
PHANPY_APP_ERROR_LOGGING: ERROR_LOGGING,
PHANPY_REFERRER_POLICY: REFERRER_POLICY,
PHANPY_DISALLOW_ROBOTS: DISALLOW_ROBOTS,
PHANPY_COMMIT_HASH: COMMIT_HASH,
PHANPY_COMMIT_TIME: COMMIT_TIME,
PHANPY_BUILD_TIME: BUILD_TIME,
PHANPY_DEV,
} = loadEnv('production', process.cwd(), allowedEnvPrefixes);

const now = new Date();
const buildTime = BUILD_TIME ? new Date(BUILD_TIME) : now;

let commitHash;
let commitTime;
let fakeCommitHash = false;
try {
const gitResult = execSync('git log -1 --format="%h %cI"').toString().trim();
const [hash, time] = gitResult.split(' ');
commitHash = hash;
commitTime = new Date(time);
} catch (error) {
// If error, means git is not installed or not a git repo (could be downloaded instead of git cloned)
// Fallback to random hash which should be different on every build run 🤞
commitHash = uid();
commitTime = now;
fakeCommitHash = true;
if (COMMIT_HASH && COMMIT_TIME) {
console.log('Using provided commit hash and timestamp');
commitHash = COMMIT_HASH;
commitTime = new Date(COMMIT_TIME);
} else {
try {
console.log('Fetching commit hash and timestamp from Git');
const gitResult = execSync('git log -1 --format="%h %cI"')
.toString()
.trim();
const [hash, time] = gitResult.split(' ');
commitHash = hash;
commitTime = new Date(time);
} catch (error) {
// If error, means git is not installed or not a git repo (could be downloaded instead of git cloned)
// Fallback to random hash which should be different on every build run 🤞
console.log(
'Falling back to randomly-generated commit hash, and current timestamp',
);
commitHash = uid();
commitTime = now;
fakeCommitHash = true;
}
}
console.log(`commit hash: ${commitHash}`);
console.log(`commit time: ${commitTime.toISOString()}`);
console.log(`build time: ${buildTime.toISOString()}`);

let rollbarCode = fs.readFileSync(resolve(__dirname, './rollbar.js'), 'utf-8');
rollbarCode = rollbarCode.replace('__PHANPY_COMMIT_HASH__', `'${commitHash}'`);
Expand Down Expand Up @@ -73,7 +93,7 @@ export default defineConfig(({ command }) => {
appType: 'mpa',
mode: NODE_ENV,
define: {
__BUILD_TIME__: JSON.stringify(now),
__BUILD_TIME__: JSON.stringify(buildTime),
__COMMIT_HASH__: JSON.stringify(commitHash),
__COMMIT_TIME__: JSON.stringify(commitTime),
__FAKE_COMMIT_HASH__: fakeCommitHash,
Expand Down Expand Up @@ -184,7 +204,7 @@ export default defineConfig(({ command }) => {
type: 'json',
output: './version.json',
data: {
buildTime: now,
buildTime,
commitHash,
},
},
Expand Down
Loading