Allow injection of the commit hash and timestamp for hermetic builds. - #1543
Merged
Conversation
Hermetic build systems, such as Nix, typically don't provide the `.git` directory, which means that building Phanpy will fall back to the randomly-generated commit hash and current timestamp. As a workaround, I propose allowing the packager to specify this during build time with environment variables. I have also added some extra logging to make it clear what's going on.
SamirTalwar
commented
Jun 19, 2026
cheeaun
requested changes
Jun 20, 2026
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hermetic build systems, such as Nix, typically don't provide the
.gitdirectory, which means that building Phanpy will fall back to the randomly-generated commit hash and current timestamp. As a workaround, I propose allowing the packager to specify this during build time with environment variables.I have also added some extra logging to make it clear what's going on.