include pager stderr in --pager failure messages - #948
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
When the pager command fails (e.g. `most` exits non-zero on input it doesn't like), the user just sees "Error: unable to run command: exit status 1" with no clue which pager failed or why. The pager's own stderr is dropped on the floor because we never assigned c.Stderr. Capture stderr into a buffer, name the pager binary in the error, and append the pager's complaint when there is one. So `PAGER=most glow -p` now reports something like pager "most" failed: exit status 1: most: Cannot ... instead of a bare "exit status 1" (charmbracelet#153). Closes charmbracelet#153 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153.
When the pager command fails (e.g. `most` exits non-zero on input it doesn't like), the user just sees "Error: unable to run command: exit status 1" with no clue which pager failed or why — the pager's own stderr is dropped because `c.Stderr` is never assigned.
Capture stderr into a buffer, name the pager binary in the error, and append the pager's complaint when there is one. `PAGER=most glow -p` now reports something like:
```
pager "most" failed: exit status 1: most: Cannot ...
```
instead of a bare "exit status 1". Same shape for the not-installed case:
```
pager "most" failed: exec: "most": executable file not found in $PATH
```
Reproduced both locally (the second one against my machine which doesn't have most). Full test suite passes.