fix(pager): use temp file and TTY for interactive pagers like most - #984
Open
syf2211 wants to merge 1 commit into
Open
fix(pager): use temp file and TTY for interactive pagers like most#984syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
Interactive pagers like `most` reject piped stdin but accept file arguments. Write rendered markdown to a temp file, pass it to the pager, and attach the controlling TTY for keyboard input. Includes stderr in pager failure messages for easier diagnosis. Fixes charmbracelet#153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
glow -pfailing whenPAGERis set to interactive pagers likemostthat reject piped stdin.Motivation
glow -ppreviously piped rendered markdown directly to the pager process stdin. Pagers such asmostexpect a file path argument and read keyboard input from the controlling terminal, so they exit with status 1 (#153).Changes
runPagerCommand()that writes rendered output to a private temp file and passes the file path to the configured pager/dev/tty(orCONIN$on Windows) for pager keyboard inputTests
go test ./...— all passNotes
mostcompatibility issue while keeping improved error messages.man,git, etc.).Fixes #153