Skip to content

D2: Renumber the bot's PRs that collide on tmt test number 50? #238

Closed
0 of 1 issue completed
Closed

Description

@cgwalters-bot

Blocks: #36

Otherwise three composefs PRs collide on merge. Doing it now costs one batch of re-approvals.

Q: tmt test number 50 is claimed by main and by bootc#2501, bootc#2503 and forge bootc#22 (and bootc#2448). Renumber the bot's PRs?

Options:
A) Yes. A worker renumbers each (58, 59, ...) with bot-tmt-number --reserve; you re-approve and the bot re-signs.
B) Renumber whichever merges last, at merge time.

Recommended: A, because of the reasons above.

Answer with a comment on this issue: an option's letter alone on the first line (e.g. B), optionally followed by your own text, or just text. Only comments by the cgwalters login count.

Unblocks:

Generated-by: https://github.com/cgwalters/#llms

Activity

  1. moved this to Needs human in Workstreamon Sep 29, 2026
  2. moved this to Needs human in Workstreamon Sep 30, 2026
  3. cgwalters-bot commented on Oct 1, 2026

    @cgwalters-bot
    CollaboratorAuthor

    Renumbered bootc#2501 (bootc edit test) from 50 to 59 while resolving its rebase conflict with main's plan-50-switch-zstd-chunked; 59 is reserved for bot/composefs-edit with bot-tmt-number. Its second commit needs re-approval anyway because of the conflict. bootc#2503, forge bootc#22 and bootc#2448 still claim 50.

    Generated-by: https://github.com/cgwalters/#llms

  4. cgwalters-bot commented on Oct 1, 2026

    @cgwalters-bot
    CollaboratorAuthor

    bootc#2503 was already merged upstream at 2026-09-30T23:13:22Z (4c8765cf), with test number 50 (plan-50-switch-zstd-chunked). #2501 moved to 59, and no other test on main uses 50 now, so no renumber is needed and nothing was rebased or pushed. This ask can be closed.

    Generated-by: https://github.com/cgwalters/#llms

  5. cgwalters commented on Oct 3, 2026

    @cgwalters
    Contributor

    Nah do a prep patch for bootc which avoids the conflict fest on tmt how about not test numbers at all? And can we refactor the generated tmt stuff so it generates separate files

  6. moved this from Needs human to In Progress in Workstreamon Oct 3, 2026
  7. cgwalters-bot commented on Oct 3, 2026

    @cgwalters-bot
    CollaboratorAuthor

    Applied: no renumbering. Prep PR cgwalters-forge/bootc#41 drops tmt test numbers and generates one file per test and plan; #36, #11, #26, #3, #117 and forge bootc#22 are told to rebase onto it once it merges. Follow-up to retire bot-tmt-number: tracker#301.

    Generated-by: https://github.com/cgwalters/#llms

  8. cgwalters-bot commented on Oct 4, 2026

    @cgwalters-bot
    CollaboratorAuthor

    Applied via prep PR cgwalters-forge/bootc#41 (no tmt numbers, one file per test/plan). bootc#2448 is an outside contributor's PR: it stays open on its own question (tracker fs-verity item) and rebases onto main after the prep lands; nothing for the bot to change there.

  9. cgwalters-bot commented on Oct 4, 2026

    @cgwalters-bot
    CollaboratorAuthor

    Applied via prep PR cgwalters-forge/bootc#41; bootc#2448 stays open on its own fs-verity question and rebases onto main after the prep lands.

  10. cgwalters-bot commented on Oct 4, 2026

    @cgwalters-bot
    CollaboratorAuthor

    Applied via prep PR cgwalters-forge/bootc#41; bootc#2448 stays open on its own fs-verity question.

  11. cgwalters-bot commented on Oct 4, 2026

    @cgwalters-bot
    CollaboratorAuthor

    Applied via prep PR cgwalters-forge/bootc#41; bootc#2448 stays open on its own question.

  12. cgwalters-bot commented on Oct 4, 2026

    @cgwalters-bot
    CollaboratorAuthor

    Applied via prep PR cgwalters-forge/bootc#41; bootc#2448 is an outside contributor's PR that stays open on its own question and rebases after the prep lands.

    Generated-by: https://github.com/cgwalters/#llms

  13. moved this from Done to In Review in Workstreamon Oct 19, 2026
  14. moved this from In Review to Done in Workstreamon Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2decisionConsolidated decision from board triagequestionFurther information is requestedtarget:bootc-dev

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions