fix(presets): exclude power plan from quick-apply presets - #56
Merged
Conversation
The Recommended / Extreme / Reset quick buttons no longer stage, monitor, or revert the Windows power plan. The active power scheme is now isolated as a one-time, user-initiated setup on the CPU / Power tab, so a preset click never overwrites (Recommended/Extreme) or undoes (Reset) the user's chosen plan. - RecommendedPreset: drop the SetPowerPlan/ResetPowerPlan calls; remove the now-orphaned SetPowerPlan, ResetPowerPlan, SafeListPlans helpers and the unused installedPlans overloads (recipe stays for the dual-CCD guardrail). - Settings UI blurbs note each preset leaves the power plan to the CPU/Power tab. - Tests: lock in that Recommended/Extreme don't touch the plan and Reset preserves a user's manual power-plan setup. - Docs: correct STAGED-APPLY-ARCHITECTURE.md and the wiki preset descriptions. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The quick-apply preset buttons (Apply recommended, Apply extreme, Reset all to defaults) previously staged the Windows power plan as part of their batch — Recommended/Extreme switched it to the CPU-aware prebuilt with Monitor + Auto-apply on, and Reset reverted it to Balanced and un-monitored it.
Per request, the active power scheme should be isolated — a one-time setup the user performs themselves on the CPU / Power tab — and no preset button should touch it. This change removes the power plan from all three presets, so a preset click never overwrites the user's chosen plan (Recommended/Extreme) nor undoes it (Reset).
Changes
RecommendedPreset.cs— drop theSetPowerPlancalls fromApplyToDraft/ApplyExtremeToDraftand theResetPowerPlancall fromResetToDefaultsToDraft. Remove the now-orphanedSetPowerPlan,ResetPowerPlan, andSafeListPlanshelpers plus the unusedinstalledPlansoverloads (the UI only called the simple overloads).recipestays — the dual-CCD service guardrail still uses it. Doc comments now list the power plan as a third deliberately-excluded category.SettingsWindow.xaml— each preset blurb states it leaves the power plan alone and points to the CPU / Power tab.STAGED-APPLY-ARCHITECTURE.md(table claimed all three staged the CPU-aware power plan) and added a note towiki/Settings-and-tabs.md.The dedicated power-plan controls (
PowerPlanCombo, the Monitor/Auto-apply checks, "Suggest best prebuilt" / "Build optimized plan") are untouched — manual one-time setup is unchanged.Verification
dotnet build— clean (0 warnings; warnings-as-errors).dotnet test— 554 passed, 0 failed.🤖 Generated with Claude Code