feat(ui): show Recommended value next to Current/Default on every setting - #45
Merged
Merged
Conversation
…ting Surface GamerGuardian's per-setting recommendation (from SettingDocsCatalog) in the Settings window alongside the existing Current/Default labels, so users can see the suggested gaming-optimized target at a glance without opening Learn more. - GlobalToggleRow / ServiceRow: add computed RecommendedText + RecommendedTextVisibility, resolved from SettingDocsCatalog.Get(SettingId). - Add a green SemiBold Recommended line to every toggle/service row template (Global gaming, Privacy, Network, Debloat, Windows AI, CPU/Power, Services) and to the static Power plan section. - Hidden automatically for any setting lacking a documented recommendation. - Tests: assert every catalog entry ships a non-empty Recommended. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Surfaces GamerGuardian's per-setting recommendation inline next to the existing Current / Default labels in the Settings window, so users see the suggested gaming-optimized target at a glance without opening Learn more.
The recommendation values already existed in
SettingDocsCatalog(they powered the Learn more expander) — this change pulls them onto the row itself.Where it appears
GlobalToggleRow.RecommendedTextServiceRow.RecommendedTextSettingDocsCatalog.Get("powerplan")RecommendedTextresolves fromSettingDocsCatalog.Get(SettingId).Recommended. Rendered green + SemiBold (matching the existing "recommended" badge), and auto-hidden for any setting lacking a documented recommendation.Scope
Tests
dotnet build— clean, 0 warnings (warnings = errors).dotnet test— 443 passed (added 2: every catalog entry has a non-empty recommendation; toggle/service id shapes resolve).🤖 Generated with Claude Code