Skip to content

test: failing reproducer - no warning for default compatibility tag #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lengau wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −0
Draft

test: failing reproducer - no warning for default compatibility tag #950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tests/unit/bases/test_ubuntu_buildd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1934,3 +1934,24 @@ def _raise_error(process) -> None:
brief="Failed to update EOL sources.",
details="* Command that failed: 'error'\n* Command exit code: 100",
)


def test_default_compat_tag_logs_warning(logs):
"""BuilddBase must warn when no custom compatibility_tag is provided.

When two different applications create BuilddBase without a custom
compatibility_tag they both get tag "buildd-base-v7", which means the
resulting base instance has the same LXD name in every project. LXD
then refuses to start the second base instance with:

Error: Failed start validation for device "eth0":
Instance DNS name "base-instance-buildd-base-v3-..." already used on network

The quick fix (per the issue) is to log a warning so the developer knows
they should pass a custom compatibility_tag.

Regression test for https://github.com/canonical/craft-providers/issues/454
"""
ubuntu.BuilddBase(alias=ubuntu.BuilddBaseAlias.JAMMY)

assert "compatibility_tag" in logs.warning
Loading