test: failing reproducer - no warning for default compatibility tag - #950
Draft
lengau wants to merge 1 commit into
Draft
test: failing reproducer - no warning for default compatibility tag#950lengau wants to merge 1 commit into
lengau wants to merge 1 commit into
Conversation
Adds a test verifying that BuilddBase logs a warning when no custom compatibility_tag is provided. Using the default tag causes all applications to share the same base instance name, leading to LXD DNS name conflicts when multiple projects use LXD simultaneously. Quick fix per issue: log a warning so developers know to set a custom compatibility_tag. Fixes: #454 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducer for #454
When two different applications create
BuilddBasewithout a customcompatibility_tag, both receive the tag"buildd-base-v7". The resulting base LXD instance gets the same name in every project, and LXD refuses to start the second one with:Failing test
test_default_compat_tag_logs_warning— shows that constructingBuilddBasewithout a customcompatibility_tagdoes not emit any warning.Fix (quick)
In
BuilddBase.__init__(), whencompatibility_tagisNone(default), emit alogger.warningtelling the developer to pass a custom tag to avoid conflicts.Closes #454