Skip to content

Review PR template: readiness-note fix and RM reviewer-assignment action#372

Merged
hdamker merged 2 commits into
camaraproject:mainfrom
hdamker:docs/review-pr-readiness-note
Jul 10, 2026
Merged

Review PR template: readiness-note fix and RM reviewer-assignment action#372
hdamker merged 2 commits into
camaraproject:mainfrom
hdamker:docs/review-pr-readiness-note

Conversation

@hdamker

@hdamker hdamker commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

enhancement/feature

What this PR does / why we need it:

Two edits to the Release Review PR body template (release_review_pr.mustache), both supporting the Release Progress Tracker's Review Queue:

  • Readiness note: the Codeowner Actions note said review starts "when all three boxes are ticked", but the deferred-validation-warnings box is optional for alpha releases, so that misfires. It now points at the explicit "ready for Release Management review" box.
  • Reviewer assignment: adds a first Release Management Actions checkbox — "Assign the Release Management reviewer(s) as assignee(s) of this PR" — and an intro line scoping the whole Release Management Actions section to RM reviewers, so codeowners don't take these boxes as their own. The PR assignee is the concrete reviewer surfaced by the Review Queue, so this makes the assignment an explicit review step.

No change to the release automation logic — these are template (instruction) edits only.

Which issue(s) this PR fixes:

Companion to camaraproject/project-administration#273 (the Review Queue view); supports the review-distribution mechanism proposed in camaraproject/ReleaseManagement#604. No tooling issue to auto-close.

Special notes for reviewers:

  • Nothing in the release automation parses these checkboxes — they are the reviewer's manual checklist, so the change is display-only.
  • Template render tests (test_template_loader.py) updated for the new checkbox.

Changelog input

release-note
Release Review PR template: gate the review-start note on the explicit readiness box, and add a Release Management action to assign the reviewer(s) as PR assignee(s).

Additional documentation

docs

hdamker added 2 commits July 9, 2026 19:14
…eckbox

The Codeowner Actions note said review starts "when all three boxes are ticked",
but the deferred-warnings box is optional for alpha releases, so that misfires.
Point the note at the explicit "ready for Release Management review" box instead.
… Review PR template

Add a first Release Management Actions checkbox — "Assign the Release Management
reviewer(s) as assignee(s) of this PR" — plus an intro line scoping the whole section
to Release Management reviewers, so codeowners do not take these boxes as their own.
The PR assignee is the concrete reviewer the Release Progress Tracker's Review Queue
surfaces, so making the assignment an explicit review step keeps that queue populated.
@hdamker hdamker requested a review from tanjadegroot July 10, 2026 08:27
@hdamker hdamker marked this pull request as ready for review July 10, 2026 08:27
@hdamker hdamker requested review from Kevsy and rartych as code owners July 10, 2026 08:27

@Kevsy Kevsy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanjadegroot

Copy link
Copy Markdown
Contributor

LGTM

@hdamker hdamker merged commit 867b7b6 into camaraproject:main Jul 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants