Align S-038 wording with the OpenAPI Format Registry framing#370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Aligns the S-038 (
camara-integer-safe-range) wording with the rationale agreed in camaraproject/Commonalities#648: the Design Guide §2.2 constraint is expressed via the OpenAPI Format Registry recommendation forint64— the 53-bit integer range and double-precision (binary64) JSON parsing — rather than JavaScript specifics (camaraproject/Commonalities#667).Reworded: rule
descriptionin.spectral-r4.yaml, the finding message and header comment incamara-integer-safe-range.js, and the test class docstring. The range threshold and rule behavior are unchanged.Which issue(s) this PR fixes:
No tooling issue — wording follow-up to camaraproject/Commonalities#648 / camaraproject/Commonalities#667.
Special notes for reviewers:
No functional change; tests assert rule code and finding paths, not message text.
TestS038IntegerSafeRangeandtest_rule_metadata_integrity.pypass.Changelog input
Additional documentation
This section can be blank.