Skip to content

Add dedicated Markdown document icon #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c3er merged 2 commits into from
Jul 19, 2026
Merged

Add dedicated Markdown document icon #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef75b3b
Add Markdown document icon
Anas-Shakeel Jul 10, 2026
875f701
rename FILE_ICON to DOCUMENT_ICON
Anas-Shakeel Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added app/assets/icon/master_file.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions app/assets/icon/md-file-icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/icon/md_file.icns
View file
Open in desktop
Binary file not shown.
Binary file added app/assets/icon/md_file.ico
View file
Open in desktop
Binary file not shown.
10 changes: 6 additions & 4 deletions build/deployConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ const APPLICATION_NAME = "Markdown Viewer"
const APPLICATION_SHORTNAME = "mdview"
const WIN_ICON = "app/assets/icon/md.ico"
const MAC_ICON = "app/assets/icon/md.icns"
const DOCUMENT_ICON = "app/assets/icon/md_file" // Electron-builder appends .icns .ico automatically

const RESPOURCE_FILES = ["README.md", "CONTRIBUTING.md", "CHANGELOG.md", "LICENSE", "doc/**"]

module.exports = {
Expand Down Expand Up @@ -66,13 +68,13 @@ module.exports = {
fileAssociations: [
{
name: "Markdown file",
ext: ".md",
icon: WIN_ICON,
ext: "md",
icon: DOCUMENT_ICON,
},
{
name: "Markdown file",
ext: ".markdown",
icon: WIN_ICON,
ext: "markdown",
icon: DOCUMENT_ICON,
},
],
}