Add dedicated Markdown document icon#84
Merged
Merged
Conversation
c3er
reviewed
Jul 11, 2026
| const MAC_ICON = "app/assets/icon/md.icns" | ||
|
|
||
| // File Association Icon | ||
| const FILE_ICON = "app/assets/icon/md_file" // Electron-builder appends .icns .ico automatically |
Owner
There was a problem hiding this comment.
DOCUMENT_ICON appears to be a better name. In my feeling, this would make the comment "File Association Icon" superfluous.
Owner
|
Thank you again! I should be able to look deeper into this and your other PR somewhen in the next days. |
Owner
|
Thank you again for your contribution. It works in macOS. Even with the limitations by Electron Builder, it's much better than before👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a dedicated icon for Markdown documents and configures it for supported platforms.
Changes
md_file.ico(Windows)md_file.icns(macOS)md-file-icon.svg(source)master_file.png(source)deployConfig.js.Testing
All existing tests pass.
Addresses #83