Skip to content

Add dedicated Markdown document icon#84

Merged
c3er merged 2 commits into
c3er:masterfrom
Anas-Shakeel:document-icon
Jul 19, 2026
Merged

Add dedicated Markdown document icon#84
c3er merged 2 commits into
c3er:masterfrom
Anas-Shakeel:document-icon

Conversation

@Anas-Shakeel

@Anas-Shakeel Anas-Shakeel commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR adds a dedicated icon for Markdown documents and configures it for supported platforms.

Changes

  • Added Markdown document icons:
    • md_file.ico (Windows)
    • md_file.icns (macOS)
    • md-file-icon.svg (source)
    • master_file.png (source)
  • Configured file associations in deployConfig.js.

Testing

  • Windows (NSIS): Custom Markdown document icon is used.
  • Windows (MSI): Falls back to the application icon (expected Electron Builder limitation).
  • Linux: Build succeeds. No custom document icon (expected Electron Builder limitation).
  • macOS: Configuration added but untested (no macOS environment available).

All existing tests pass.

Addresses #83

Comment thread build/deployConfig.js Outdated
const MAC_ICON = "app/assets/icon/md.icns"

// File Association Icon
const FILE_ICON = "app/assets/icon/md_file" // Electron-builder appends .icns .ico automatically

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOCUMENT_ICON appears to be a better name. In my feeling, this would make the comment "File Association Icon" superfluous.

@c3er

c3er commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Thank you again! I should be able to look deeper into this and your other PR somewhen in the next days.

@c3er
c3er merged commit dbe452b into c3er:master Jul 19, 2026
2 checks passed
@c3er

c3er commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Thank you again for your contribution.

It works in macOS. Even with the limitations by Electron Builder, it's much better than before👍

@Anas-Shakeel
Anas-Shakeel deleted the document-icon branch July 19, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants