Fix landing page a11y regression + stale FAQ doc comment#27
Merged
Conversation
Restore aria-hidden="true" on the decorative .ledger sample-entries card so screen readers stop announcing fictional bookings (Bella $180 boarding, Otis $22 dog walk, ...) as real content — the redesign in #26 dropped it while the inner stamp/marginalia kept theirs. Also correct the LANDING_HTML doc comment, which still claimed the FAQ used <details>/<summary>; the redesign made it a static Q&A with no <details> element, so the comment now says the page has no interactivity at all. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two follow-up nits from the #26 landing page review:
.ledgersample card lost itsaria-hidden="true", so screen readers announced the fictional sample entries (Bella $180 boarding, Otis $22 dog walk, Mochi $240 house-sit) as real content. Restored it — the inner stamp SVG and marginalia already hadaria-hidden, so this re-hides the entries and makes the whole decorative card consistently hidden.LANDING_HTMLdoc comment above the template still claimed the FAQ used<details>/<summary>, but the redesign replaced it with a static Q&A. Confirmed via grep there are zero<details>/<summary>in the file and corrected the comment to say the page has no interactivity at all (script-free, native HTML/CSS only).No behavioral changes beyond the
aria-hiddenattribute; CSP invariant preserved (root page stays script-free, inline styles only — verified via grep that the only<scriptin the body is the HTML-escaped<scriptsnippet).Test plan
npm run typecheck— passesnpm test— 336/336 tests pass (46 files), includingserver/__tests__/landing.test.tsnpm run format— clean onserver/index.ts(pre-existing drift in.claude/settings.local.jsonis unrelated)